sam/pronounscc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(api): don't panic if PATCH /users/@me does not have "fields" set

Browse source
This commit is contained in:
Sam 2022-06-17 16:10:32 +02:00
parent 59a1a3fb9b
commit 6cc4d4c41d
1 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
backend/routes/user/patch_user.go
View file

@ -71,20 +71,22 @@ func (s *Server) patchUser(w http.ResponseWriter, r *http.Request) error {
} }
} }
// max 25 fields if (req.Fields) != nil {
if len(*req.Fields) > db.MaxFields { // max 25 fields
return server.APIError{ if len(*req.Fields) > db.MaxFields {
Code: server.ErrBadRequest,
Details: fmt.Sprintf("Too many fields (max %d, current %d)", db.MaxFields, len(*req.Fields)),
}
}
// validate all fields
for i, field := range *req.Fields {
if s := field.Validate(); s != "" {
return server.APIError{ return server.APIError{
Code: server.ErrBadRequest, Code: server.ErrBadRequest,
Details: fmt.Sprintf("field %d: %s", i, s), Details: fmt.Sprintf("Too many fields (max %d, current %d)", db.MaxFields, len(*req.Fields)),
}
}
// validate all fields
for i, field := range *req.Fields {
if s := field.Validate(); s != "" {
return server.APIError{
Code: server.ErrBadRequest,
Details: fmt.Sprintf("field %d: %s", i, s),
}
} }
} }
} }