sam/pronounscc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: reject instance domains with @ in them

Browse source
This commit is contained in:
Sam 2023-04-18 02:15:45 +02:00
parent 5c8c6eed63
commit 6131884ba7
Signed by: sam
GPG key ID: B4EF20DDE721CAA1
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
backend/routes/auth/fediverse.go
View file

@ -25,6 +25,11 @@ func (s *Server) getFediverseURL(w http.ResponseWriter, r *http.Request) error {
return server.APIError{Code: server.ErrBadRequest, Details: "Instance URL is empty"} return server.APIError{Code: server.ErrBadRequest, Details: "Instance URL is empty"}
} }
// Too many people tried using @username@fediverse.example despite the warning
if strings.Contains(instance, "@") {
return server.APIError{Code: server.ErrBadRequest, Details: "Instance URL should only be the base URL, without username"}
}
app, err := s.DB.FediverseApp(ctx, instance) app, err := s.DB.FediverseApp(ctx, instance)
if err != nil { if err != nil {
return s.noAppFediverseURL(ctx, w, r, instance) return s.noAppFediverseURL(ctx, w, r, instance)