chore(backend): add roslynator and fix diagnostics

.editorconfig

@@ -45,5 +45,8 @@ resharper_wrap_chained_binary_patterns = chop_if_long
 resharper_wrap_list_pattern = chop_always
 resharper_wrap_object_and_collection_initializer_style = chop_always
 
+# Roslynator properties
+dotnet_diagnostic.RCS1194.severity = none
+
 [*generated.cs]
 generated_code = true

Foxnouns.Backend/Controllers/Authentication/AuthController.cs

@@ -38,7 +38,7 @@ public class AuthController(
         if (config.DiscordAuth is { ClientId: not null, ClientSecret: not null })
         {
             discord =
-                $"https://discord.com/oauth2/authorize?response_type=code"
+                "https://discord.com/oauth2/authorize?response_type=code"
                 + $"&client_id={config.DiscordAuth.ClientId}&scope=identify"
                 + $"&prompt=none&state={state}"
                 + $"&redirect_uri={HttpUtility.UrlEncode($"{config.BaseUrl}/auth/callback/discord")}";

Foxnouns.Backend/Controllers/Authentication/DiscordAuthController.cs

@@ -104,7 +104,7 @@ public class DiscordAuthController(
         );
 
         string url =
-            $"https://discord.com/oauth2/authorize?response_type=code"
+            "https://discord.com/oauth2/authorize?response_type=code"
             + $"&client_id={config.DiscordAuth.ClientId}&scope=identify"
             + $"&prompt=none&state={state}"
             + $"&redirect_uri={HttpUtility.UrlEncode($"{config.BaseUrl}/auth/callback/discord")}";

Foxnouns.Backend/Controllers/Authentication/EmailAuthController.cs

@@ -48,7 +48,9 @@ public class EmailAuthController(
                 ct
             )
         )
+        {
             return NoContent();
+        }
 
         mailService.QueueAccountCreationEmail(req.Email, state);
         return NoContent();

Foxnouns.Backend/Controllers/FlagsController.cs

@@ -124,7 +124,9 @@ public class FlagsController(
             }
         }
         else
+        {
             _logger.Debug("Flag file {Hash} is used by other flags, not deleting", hash);
+        }
 
         await tx.CommitAsync();
 

Foxnouns.Backend/Controllers/InternalController.cs

@@ -93,12 +93,14 @@ public partial class InternalController(DatabaseContext db) : ControllerBase
             HttpMethodAttribute? httpMethodAttribute =
                 endpoint.Metadata.GetMetadata<HttpMethodAttribute>();
             if (
-                httpMethodAttribute != null
-                && !httpMethodAttribute.HttpMethods.Any(x =>
+                httpMethodAttribute?.HttpMethods.Any(x =>
                     x.Equals(requestMethod, StringComparison.OrdinalIgnoreCase)
-                )
+                ) == false
             )
+            {
                 continue;
+            }
+
             return endpoint;
         }
 

Foxnouns.Backend/Controllers/MembersController.cs

@@ -238,7 +238,7 @@ public class MembersController(
             throw new ApiError.BadRequest(
                 "A member with that name already exists",
                 "name",
-                req.Name!
+                req.Name
             );
         }
 

Foxnouns.Backend/Controllers/UsersController.cs

@@ -135,7 +135,9 @@ public class UsersController(
             else
             {
                 if (TimeZoneInfo.TryFindSystemTimeZoneById(req.Timezone, out _))
+                {
                     user.Timezone = req.Timezone;
+                }
                 else
                 {
                     errors.Add(
@@ -174,7 +176,7 @@ public class UsersController(
             throw new ApiError.BadRequest(
                 "That username is already taken.",
                 "username",
-                req.Username!
+                req.Username
             );
         }
 

Foxnouns.Backend/Database/DatabaseContext.cs

@@ -44,18 +44,18 @@ public class DatabaseContext(DbContextOptions options) : DbContext(options)
             .UseSnakeCaseNamingConvention()
             .UseExceptionProcessor();
 
-    public DbSet<User> Users { get; init; }
-    public DbSet<Member> Members { get; init; }
-    public DbSet<AuthMethod> AuthMethods { get; init; }
-    public DbSet<FediverseApplication> FediverseApplications { get; init; }
-    public DbSet<Token> Tokens { get; init; }
-    public DbSet<Application> Applications { get; init; }
-    public DbSet<TemporaryKey> TemporaryKeys { get; init; }
-    public DbSet<DataExport> DataExports { get; init; }
+    public DbSet<User> Users { get; init; } = null!;
+    public DbSet<Member> Members { get; init; } = null!;
+    public DbSet<AuthMethod> AuthMethods { get; init; } = null!;
+    public DbSet<FediverseApplication> FediverseApplications { get; init; } = null!;
+    public DbSet<Token> Tokens { get; init; } = null!;
+    public DbSet<Application> Applications { get; init; } = null!;
+    public DbSet<TemporaryKey> TemporaryKeys { get; init; } = null!;
+    public DbSet<DataExport> DataExports { get; init; } = null!;
 
-    public DbSet<PrideFlag> PrideFlags { get; init; }
-    public DbSet<UserFlag> UserFlags { get; init; }
-    public DbSet<MemberFlag> MemberFlags { get; init; }
+    public DbSet<PrideFlag> PrideFlags { get; init; } = null!;
+    public DbSet<UserFlag> UserFlags { get; init; } = null!;
+    public DbSet<MemberFlag> MemberFlags { get; init; } = null!;
 
     protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
     {

Foxnouns.Backend/Database/Migrations/20240527132444_Init.cs

@@ -24,10 +24,7 @@ namespace Foxnouns.Backend.Database.Migrations
                     client_secret = table.Column<string>(type: "text", nullable: false),
                     instance_type = table.Column<int>(type: "integer", nullable: false),
                 },
-                constraints: table =>
-                {
-                    table.PrimaryKey("pk_fediverse_applications", x => x.id);
-                }
+                constraints: table => table.PrimaryKey("pk_fediverse_applications", x => x.id)
             );
 
             migrationBuilder.CreateTable(
@@ -46,10 +43,7 @@ namespace Foxnouns.Backend.Database.Migrations
                     names = table.Column<string>(type: "jsonb", nullable: false),
                     pronouns = table.Column<string>(type: "jsonb", nullable: false),
                 },
-                constraints: table =>
-                {
-                    table.PrimaryKey("pk_users", x => x.id);
-                }
+                constraints: table => table.PrimaryKey("pk_users", x => x.id)
             );
 
             migrationBuilder.CreateTable(

Foxnouns.Backend/Database/Migrations/20240528125310_AddApplications.cs

@@ -26,7 +26,7 @@ namespace Foxnouns.Backend.Database.Migrations
                 table: "tokens",
                 type: "bytea",
                 nullable: false,
-                defaultValue: new byte[0]
+                defaultValue: Array.Empty<byte>()
             );
 
             migrationBuilder.CreateTable(
@@ -40,10 +40,7 @@ namespace Foxnouns.Backend.Database.Migrations
                     scopes = table.Column<string[]>(type: "text[]", nullable: false),
                     redirect_uris = table.Column<string[]>(type: "text[]", nullable: false),
                 },
-                constraints: table =>
-                {
-                    table.PrimaryKey("pk_applications", x => x.id);
-                }
+                constraints: table => table.PrimaryKey("pk_applications", x => x.id)
             );
 
             migrationBuilder.CreateIndex(

Foxnouns.Backend/Database/Migrations/20240611225328_AddTemporaryKeyCache.cs

@@ -32,10 +32,7 @@ namespace Foxnouns.Backend.Database.Migrations
                         nullable: false
                     ),
                 },
-                constraints: table =>
-                {
-                    table.PrimaryKey("pk_temporary_keys", x => x.id);
-                }
+                constraints: table => table.PrimaryKey("pk_temporary_keys", x => x.id)
             );
 
             migrationBuilder.CreateIndex(

Foxnouns.Backend/Foxnouns.Backend.csproj

@@ -30,6 +30,10 @@
         <PackageReference Include="Npgsql.Json.NET" Version="8.0.3"/>
         <PackageReference Include="prometheus-net" Version="8.2.1"/>
         <PackageReference Include="prometheus-net.AspNetCore" Version="8.2.1"/>
+        <PackageReference Include="Roslynator.Analyzers" Version="4.12.9">
+            <PrivateAssets>all</PrivateAssets>
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
         <PackageReference Include="Sentry.AspNetCore" Version="4.9.0"/>
         <PackageReference Include="Serilog" Version="4.0.1"/>
         <PackageReference Include="Serilog.AspNetCore" Version="8.0.1"/>

Foxnouns.Backend/Jobs/CreateDataExportInvocable.cs

@@ -57,7 +57,7 @@ public class CreateDataExportInvocable(
 
         _logger.Information("Generating data export for user {UserId}", user.Id);
 
-        using var stream = new MemoryStream();
+        await using var stream = new MemoryStream();
         using var zip = new ZipArchive(stream, ZipArchiveMode.Create, true);
         zip.Comment =
             $"This archive for {user.Username} ({user.Id}) was generated at  {InstantPattern.General.Format(clock.GetCurrentInstant())}";

Foxnouns.Backend/Middleware/AuthorizationMiddleware.cs

@@ -44,7 +44,9 @@ public class AuthorizationMiddleware : IMiddleware
             && token.User.Role != UserRole.Admin
             && token.User.Role != UserRole.Moderator
         )
+        {
             throw new ApiError.Forbidden("This endpoint can only be used by moderators.");
+        }
 
         await next(ctx);
     }

Foxnouns.Backend/Services/Auth/RemoteAuthService.cs

@@ -142,6 +142,8 @@ public class RemoteAuthService(
             || accountState.UserId != userId
             || (instance != null && accountState.Instance != instance)
         )
+        {
             throw new ApiError.BadRequest("Invalid state", "state", state);
+        }
     }
 }

Foxnouns.Backend/Services/UserRendererService.cs

@@ -74,7 +74,9 @@ public class UserRendererService(
             user.Timezone != null
             && TimeZoneInfo.TryFindSystemTimeZoneById(user.Timezone, out TimeZoneInfo? tz)
         )
+        {
             utcOffset = (int)tz.GetUtcOffset(DateTimeOffset.UtcNow).TotalSeconds;
+        }
 
         return new UserResponse(
             user.Id,

Foxnouns.Backend/Utils/PatchRequest.cs

@@ -5,10 +5,11 @@ using Newtonsoft.Json.Serialization;
 namespace Foxnouns.Backend.Utils;
 
 /// <summary>
-/// A base class used for PATCH requests which stores information on whether a key is explicitly set to null or not passed at all.
-///
+/// <para>A base class used for PATCH requests which stores information on whether a key is explicitly set to null or not passed at all.</para>
+/// <para>
 /// HasProperty() should not be used for properties that cannot be set to null--a null value should be treated
 /// as an unset value in those cases.
+/// </para>
 /// </summary>
 public abstract class PatchRequest
 {

Foxnouns.Backend/Utils/ValidationUtils.Strings.cs

@@ -63,7 +63,10 @@ public static partial class ValidationUtils
                 string.Equals(u, username, StringComparison.InvariantCultureIgnoreCase)
             )
         )
+        {
             return ValidationError.GenericValidationError("Username is not allowed", username);
+        }
+
         return null;
     }
 
@@ -89,7 +92,10 @@ public static partial class ValidationUtils
                 string.Equals(u, memberName, StringComparison.InvariantCultureIgnoreCase)
             )
         )
+        {
             return ValidationError.GenericValidationError("Name is not allowed", memberName);
+        }
+
         return null;
     }
 

Foxnouns.Backend/packages.lock.json

@@ -194,6 +194,12 @@
           "prometheus-net": "8.2.1"
         }
       },
+      "Roslynator.Analyzers": {
+        "type": "Direct",
+        "requested": "[4.12.9, )",
+        "resolved": "4.12.9",
+        "contentHash": "X6lDpN/D5wuinq37KIx+l3GSUe9No+8bCjGBTI5sEEtxapLztkHg6gzNVhMXpXw8P+/5gFYxTXJ5Pf8O4iNz/w=="
+      },
       "Sentry.AspNetCore": {
         "type": "Direct",
         "requested": "[4.9.0, )",