From f3bb2d5d019199dfd2898add8b6935adc5339fa7 Mon Sep 17 00:00:00 2001
From: sam <sam@vulpine.solutions>
Date: Mon, 2 Dec 2024 15:06:17 +0100
Subject: [PATCH] fix(frontend): add autocomplete=off tags to most inputs

---
 .../src/lib/components/editor/FieldEditor.svelte         | 3 ++-
 .../src/lib/components/editor/FieldEntryEditor.svelte    | 2 +-
 .../src/lib/components/editor/FieldsEditor.svelte        | 1 +
 .../src/lib/components/editor/PronounEntryEditor.svelte  | 3 ++-
 .../src/lib/components/editor/PronounsEditor.svelte      | 2 +-
 Foxnouns.Frontend/src/routes/settings/+page.svelte       | 8 +++++++-
 .../src/routes/settings/members/[id]/+page.svelte        | 9 ++++++++-
 .../src/routes/settings/members/new/+page.svelte         | 2 +-
 .../src/routes/settings/profile/+page.svelte             | 2 ++
 9 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/Foxnouns.Frontend/src/lib/components/editor/FieldEditor.svelte b/Foxnouns.Frontend/src/lib/components/editor/FieldEditor.svelte
index c2536dd..b409290 100644
--- a/Foxnouns.Frontend/src/lib/components/editor/FieldEditor.svelte
+++ b/Foxnouns.Frontend/src/lib/components/editor/FieldEditor.svelte
@@ -65,7 +65,7 @@
 				onclick={() => move(index, false)}
 			/>
 			<InputGroupText>{$t("editor.field-name")}</InputGroupText>
-			<input class="form-control" bind:value={name} />
+			<input class="form-control" bind:value={name} autocomplete="off" />
 			<IconButton
 				color="danger"
 				icon="trash3"
@@ -88,6 +88,7 @@
 		class="form-control"
 		bind:value={newEntry}
 		placeholder={$t("editor.new-entry")}
+		autocomplete="off"
 	/>
 	<IconButton type="submit" color="success" icon="plus" tooltip={$t("editor.add-entry")} />
 </form>
diff --git a/Foxnouns.Frontend/src/lib/components/editor/FieldEntryEditor.svelte b/Foxnouns.Frontend/src/lib/components/editor/FieldEntryEditor.svelte
index 65c2355..5e407ac 100644
--- a/Foxnouns.Frontend/src/lib/components/editor/FieldEntryEditor.svelte
+++ b/Foxnouns.Frontend/src/lib/components/editor/FieldEntryEditor.svelte
@@ -40,7 +40,7 @@
 		tooltip={$t("editor.move-entry-down")}
 		onclick={() => moveValue(index, false)}
 	/>
-	<input type="text" class="form-control" bind:value={value.value} />
+	<input type="text" class="form-control" bind:value={value.value} autocomplete="off" />
 	<ButtonDropdown>
 		<span use:tippy={{ content: status.tooltip }}>
 			<DropdownToggle color="secondary" caret>
diff --git a/Foxnouns.Frontend/src/lib/components/editor/FieldsEditor.svelte b/Foxnouns.Frontend/src/lib/components/editor/FieldsEditor.svelte
index 6bbba9c..bcd3e78 100644
--- a/Foxnouns.Frontend/src/lib/components/editor/FieldsEditor.svelte
+++ b/Foxnouns.Frontend/src/lib/components/editor/FieldsEditor.svelte
@@ -56,6 +56,7 @@
 			class="form-control"
 			bind:value={newFieldName}
 			placeholder={$t("editor.field-name")}
+			autocomplete="off"
 		/>
 		<IconButton type="submit" color="success" icon="plus" tooltip={$t("editor.add-field")} />
 	</form>
diff --git a/Foxnouns.Frontend/src/lib/components/editor/PronounEntryEditor.svelte b/Foxnouns.Frontend/src/lib/components/editor/PronounEntryEditor.svelte
index aee6859..bcf5c15 100644
--- a/Foxnouns.Frontend/src/lib/components/editor/PronounEntryEditor.svelte
+++ b/Foxnouns.Frontend/src/lib/components/editor/PronounEntryEditor.svelte
@@ -50,7 +50,7 @@
 			tooltip={$t("editor.move-entry-down")}
 			onclick={() => moveValue(index, true)}
 		/>
-		<input type="text" class="form-control" bind:value={value.value} />
+		<input type="text" class="form-control" bind:value={value.value} autocomplete="off" />
 		<ButtonDropdown>
 			<span use:tippy={{ content: status.tooltip }}>
 				<DropdownToggle color="secondary" caret>
@@ -88,6 +88,7 @@
 				type="text"
 				class="form-control"
 				bind:value={value.display_text}
+				autocomplete="off"
 			/>
 			<IconButton id="display-help" icon="question" tooltip="Help" color="secondary" />
 			<!-- TODO: remove children={false} once sveltestrap is updated
diff --git a/Foxnouns.Frontend/src/lib/components/editor/PronounsEditor.svelte b/Foxnouns.Frontend/src/lib/components/editor/PronounsEditor.svelte
index 9219c02..5f49e73 100644
--- a/Foxnouns.Frontend/src/lib/components/editor/PronounsEditor.svelte
+++ b/Foxnouns.Frontend/src/lib/components/editor/PronounsEditor.svelte
@@ -60,6 +60,6 @@
 {/each}
 
 <form class="input-group m-1" onsubmit={addEntry}>
-	<input type="text" class="form-control" bind:value={newEntry} />
+	<input type="text" class="form-control" bind:value={newEntry} autocomplete="off" />
 	<IconButton type="submit" color="success" icon="plus" tooltip={$t("editor.add-entry")} />
 </form>
diff --git a/Foxnouns.Frontend/src/routes/settings/+page.svelte b/Foxnouns.Frontend/src/routes/settings/+page.svelte
index cfd0b88..b7be972 100644
--- a/Foxnouns.Frontend/src/routes/settings/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/settings/+page.svelte
@@ -23,7 +23,13 @@
 		<form method="POST" action="?/changeUsername">
 			<FormGroup class="mb-3">
 				<InputGroup class="m-1 mt-3 w-md-75">
-					<Input type="text" value={data.user.username} name="username" required />
+					<Input
+						type="text"
+						value={data.user.username}
+						name="username"
+						required
+						autocomplete="off"
+					/>
 					<Button type="submit" color="secondary">{$t("settings.change-username-button")}</Button>
 				</InputGroup>
 			</FormGroup>
diff --git a/Foxnouns.Frontend/src/routes/settings/members/[id]/+page.svelte b/Foxnouns.Frontend/src/routes/settings/members/[id]/+page.svelte
index 04637ee..7819548 100644
--- a/Foxnouns.Frontend/src/routes/settings/members/[id]/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/settings/members/[id]/+page.svelte
@@ -84,7 +84,13 @@
 		<h4>{$t("edit-profile.member-name")}</h4>
 		<form method="POST" action="?/changeName" class="mb-3">
 			<InputGroup>
-				<input name="name" class="form-control" type="text" value={data.member.name} />
+				<input
+					name="name"
+					class="form-control"
+					type="text"
+					value={data.member.name}
+					autocomplete="off"
+				/>
 				<button type="submit" class="btn btn-primary">
 					{$t("change")}
 				</button>
@@ -99,6 +105,7 @@
 					name="display-name"
 					placeholder={data.member.name}
 					value={data.member.display_name !== data.member.name ? data.member.display_name : null}
+					autocomplete="off"
 				/>
 				<button class="btn btn-primary" type="submit">{$t("change")}</button>
 			</InputGroup>
diff --git a/Foxnouns.Frontend/src/routes/settings/members/new/+page.svelte b/Foxnouns.Frontend/src/routes/settings/members/new/+page.svelte
index da17621..7999be2 100644
--- a/Foxnouns.Frontend/src/routes/settings/members/new/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/settings/members/new/+page.svelte
@@ -16,7 +16,7 @@
 <form method="POST">
 	<div class="my-3">
 		<label class="form-label" for="name">{$t("settings.create-member-name-label")}</label>
-		<input class="form-control" type="text" id="name" name="name" required />
+		<input class="form-control" type="text" id="name" name="name" required autocomplete="off" />
 	</div>
 	<button class="btn btn-primary" type="submit">{$t("profile.create-member-button")}</button>
 </form>
diff --git a/Foxnouns.Frontend/src/routes/settings/profile/+page.svelte b/Foxnouns.Frontend/src/routes/settings/profile/+page.svelte
index c603ab6..d343ab5 100644
--- a/Foxnouns.Frontend/src/routes/settings/profile/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/settings/profile/+page.svelte
@@ -114,6 +114,7 @@
 					name="display-name"
 					placeholder={data.user.username}
 					value={data.user.display_name}
+					autocomplete="off"
 				/>
 				<button class="btn btn-primary" type="submit">{$t("change")}</button>
 			</InputGroup>
@@ -136,6 +137,7 @@
 				class="form-control"
 				value={data.user.member_title}
 				placeholder={$t("profile.default-members-header")}
+				autocomplete="off"
 			/>
 			<p class="text-muted mt-1">
 				<Icon name="info-circle-fill" aria-hidden />