From bcdb2f9540871fedded4b59b70663e7d23a89c71 Mon Sep 17 00:00:00 2001
From: sam <sam@vulpine.solutions>
Date: Thu, 17 Apr 2025 15:29:55 +0200
Subject: [PATCH] fix(frontend): actually show eslint errors in vscode, fix
 eslint errors

---
 Foxnouns.Frontend/.vscode/settings.json            |  3 ++-
 .../src/lib/components/GlobalNotice.svelte         |  1 +
 .../lib/components/admin/AuditLogEntryCard.svelte  |  1 +
 .../components/admin/ClosedReportAuditLog.svelte   |  1 +
 Foxnouns.Frontend/src/lib/i18n/locales/en.json     |  3 ++-
 .../src/routes/admin/reports/[id]/+page.svelte     |  1 +
 .../src/routes/page/[page]/+page.svelte            |  1 +
 .../src/routes/settings/prefs/+page.svelte         | 14 +++++++++++++-
 8 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/Foxnouns.Frontend/.vscode/settings.json b/Foxnouns.Frontend/.vscode/settings.json
index 5703e7f..c5d12a5 100644
--- a/Foxnouns.Frontend/.vscode/settings.json
+++ b/Foxnouns.Frontend/.vscode/settings.json
@@ -4,5 +4,6 @@
 	"i18n-ally.localesPaths": ["src/lib/i18n", "src/lib/i18n/locales"],
 	"i18n-ally.keystyle": "nested",
 	"explorer.sortOrder": "filesFirst",
-	"explorer.compactFolders": false
+	"explorer.compactFolders": false,
+	"eslint.validate": ["javascript", "javascriptreact", "svelte"]
 }
diff --git a/Foxnouns.Frontend/src/lib/components/GlobalNotice.svelte b/Foxnouns.Frontend/src/lib/components/GlobalNotice.svelte
index 3d1c718..c8a55f1 100644
--- a/Foxnouns.Frontend/src/lib/components/GlobalNotice.svelte
+++ b/Foxnouns.Frontend/src/lib/components/GlobalNotice.svelte
@@ -34,6 +34,7 @@
 {#if renderNotice}
 	<div class="alert alert-light" role="alert">
 		<div>
+			<!-- eslint-disable-next-line svelte/no-at-html-tags -->
 			{@html renderedMessage}
 		</div>
 		{#if canDismiss}
diff --git a/Foxnouns.Frontend/src/lib/components/admin/AuditLogEntryCard.svelte b/Foxnouns.Frontend/src/lib/components/admin/AuditLogEntryCard.svelte
index 02872d4..b1d777a 100644
--- a/Foxnouns.Frontend/src/lib/components/admin/AuditLogEntryCard.svelte
+++ b/Foxnouns.Frontend/src/lib/components/admin/AuditLogEntryCard.svelte
@@ -59,6 +59,7 @@
 	{#if reason}
 		<details>
 			<summary>Reason</summary>
+			<!-- eslint-disable-next-line svelte/no-at-html-tags -->
 			{@html reason}
 		</details>
 	{:else}
diff --git a/Foxnouns.Frontend/src/lib/components/admin/ClosedReportAuditLog.svelte b/Foxnouns.Frontend/src/lib/components/admin/ClosedReportAuditLog.svelte
index 7f7f3b0..589539f 100644
--- a/Foxnouns.Frontend/src/lib/components/admin/ClosedReportAuditLog.svelte
+++ b/Foxnouns.Frontend/src/lib/components/admin/ClosedReportAuditLog.svelte
@@ -29,6 +29,7 @@
 	<h4>Reason</h4>
 	<p>
 		{#if entry.reason}
+			<!-- eslint-disable-next-line svelte/no-at-html-tags -->
 			{@html renderMarkdown(entry.reason)}
 		{:else}
 			<em class="text-secondary">(no reason given)</em>
diff --git a/Foxnouns.Frontend/src/lib/i18n/locales/en.json b/Foxnouns.Frontend/src/lib/i18n/locales/en.json
index dc74d2f..22428f7 100644
--- a/Foxnouns.Frontend/src/lib/i18n/locales/en.json
+++ b/Foxnouns.Frontend/src/lib/i18n/locales/en.json
@@ -296,7 +296,8 @@
 		"custom-preference-notice": "Want to edit your custom preferences?",
 		"custom-preference-notice-link": "Go to settings",
 		"crop-avatar-header": "Crop avatar",
-		"crop-avatar-button": "Crop"
+		"crop-avatar-button": "Crop",
+		"max-custom-preferences": "You have reached the maximum amount of custom preferences ({{current}}/{{max}}), and cannot add new ones."
 	},
 	"cancel": "Cancel",
 	"report": {
diff --git a/Foxnouns.Frontend/src/routes/admin/reports/[id]/+page.svelte b/Foxnouns.Frontend/src/routes/admin/reports/[id]/+page.svelte
index 2e953d5..8a1ae08 100644
--- a/Foxnouns.Frontend/src/routes/admin/reports/[id]/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/admin/reports/[id]/+page.svelte
@@ -56,6 +56,7 @@
 		<h3>Context</h3>
 		<p>
 			{#if report.context}
+				<!-- eslint-disable-next-line svelte/no-at-html-tags -->
 				{@html renderMarkdown(report.context)}
 			{:else}
 				<em>(no context given)</em>
diff --git a/Foxnouns.Frontend/src/routes/page/[page]/+page.svelte b/Foxnouns.Frontend/src/routes/page/[page]/+page.svelte
index a156d0a..3af7b11 100644
--- a/Foxnouns.Frontend/src/routes/page/[page]/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/page/[page]/+page.svelte
@@ -18,5 +18,6 @@
 </svelte:head>
 
 <div class="container">
+	<!-- eslint-disable-next-line svelte/no-at-html-tags -->
 	{@html md}
 </div>
diff --git a/Foxnouns.Frontend/src/routes/settings/prefs/+page.svelte b/Foxnouns.Frontend/src/routes/settings/prefs/+page.svelte
index 2cc4f6a..74f5154 100644
--- a/Foxnouns.Frontend/src/routes/settings/prefs/+page.svelte
+++ b/Foxnouns.Frontend/src/routes/settings/prefs/+page.svelte
@@ -7,6 +7,7 @@
 	import { t } from "$lib/i18n";
 	import log from "$lib/log";
 	import type { PageData } from "./$types";
+	import InfoCircleFill from "svelte-bootstrap-icons/lib/InfoCircleFill.svelte";
 
 	type Props = { data: PageData };
 	let { data }: Props = $props();
@@ -84,8 +85,19 @@
 	{$t("settings.custom-preferences-title")}
 	<div class="btn-group">
 		<button class="btn btn-primary" onclick={() => save()}>{$t("save-changes")}</button>
-		<button class="btn btn-success" onclick={add}>{$t("editor.add-custom-preference")}</button>
+		<button class="btn btn-success" onclick={add} disabled={!canAdd}
+			>{$t("editor.add-custom-preference")}</button
+		>
 	</div>
+	{#if !canAdd}
+		<div>
+			<InfoCircleFill aria-hidden />
+			{$t("editor.max-custom-preferences", {
+				current: customPreferences.length,
+				max: data.meta.limits.custom_preferences,
+			})}
+		</div>
+	{/if}
 </h3>
 
 <FormStatusMarker form={ok} />