feat(backend): update flag endpoint

This commit is contained in:
sam 2024-09-27 00:38:34 +02:00
parent 758ab9ec5b
commit 6a4aa8064a
Signed by: sam
GPG key ID: B4EF20DDE721CAA1

View file

@ -5,6 +5,7 @@ using Foxnouns.Backend.Extensions;
using Foxnouns.Backend.Jobs; using Foxnouns.Backend.Jobs;
using Foxnouns.Backend.Middleware; using Foxnouns.Backend.Middleware;
using Foxnouns.Backend.Services; using Foxnouns.Backend.Services;
using Foxnouns.Backend.Utils;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore;
@ -36,6 +37,8 @@ public class FlagsController(
[ProducesResponseType<PrideFlagResponse>(statusCode: StatusCodes.Status202Accepted)] [ProducesResponseType<PrideFlagResponse>(statusCode: StatusCodes.Status202Accepted)]
public IActionResult CreateFlag([FromBody] CreateFlagRequest req) public IActionResult CreateFlag([FromBody] CreateFlagRequest req)
{ {
ValidationUtils.Validate(ValidateFlag(req.Name, req.Description, req.Image));
var id = snowflakeGenerator.GenerateSnowflake(); var id = snowflakeGenerator.GenerateSnowflake();
queue.QueueInvocableWithPayload<CreateFlagInvocable, CreateFlagPayload>( queue.QueueInvocableWithPayload<CreateFlagInvocable, CreateFlagPayload>(
@ -45,8 +48,35 @@ public class FlagsController(
} }
public record CreateFlagRequest(string Name, string Image, string? Description); public record CreateFlagRequest(string Name, string Image, string? Description);
private record CreateFlagResponse(Snowflake Id, string Name, string? Description); private record CreateFlagResponse(Snowflake Id, string Name, string? Description);
[HttpPatch("{id}")]
[Authorize("user.update")]
public async Task<IActionResult> UpdateFlagAsync(Snowflake id, [FromBody] UpdateFlagRequest req)
{
ValidationUtils.Validate(ValidateFlag(req.Name, req.Description, null));
var flag = await db.PrideFlags.FirstOrDefaultAsync(f => f.Id == id && f.UserId == CurrentUser!.Id);
if (flag == null) throw new ApiError.NotFound("Unknown flag ID, or it's not your flag.");
if (req.Name != null) flag.Name = req.Name;
if (req.HasProperty(nameof(req.Description)))
flag.Description = req.Description;
db.Update(flag);
await db.SaveChangesAsync();
return Ok(ToResponse(flag));
}
public class UpdateFlagRequest : PatchRequest
{
public string? Name { get; init; }
public string? Description { get; init; }
}
[HttpDelete("{id}")] [HttpDelete("{id}")]
[Authorize("user.update")] [Authorize("user.update")]
public async Task<IActionResult> DeleteFlagAsync(Snowflake id) public async Task<IActionResult> DeleteFlagAsync(Snowflake id)
@ -73,7 +103,8 @@ public class FlagsController(
{ {
_logger.Error(e, "Error deleting flag file {Hash}", hash); _logger.Error(e, "Error deleting flag file {Hash}", hash);
} }
} else _logger.Debug("Flag file {Hash} is used by other flags, not deleting", hash); }
else _logger.Debug("Flag file {Hash} is used by other flags, not deleting", hash);
await tx.CommitAsync(); await tx.CommitAsync();
@ -88,4 +119,52 @@ public class FlagsController(
string ImageUrl, string ImageUrl,
string Name, string Name,
string? Description); string? Description);
private static List<(string, ValidationError?)> ValidateFlag(string? name, string? description, string? imageData)
{
var errors = new List<(string, ValidationError?)>();
if (name != null)
{
switch (name.Length)
{
case < 1:
errors.Add(("name", ValidationError.LengthError("Name is too short", 1, 100, name.Length)));
break;
case > 100:
errors.Add(("name", ValidationError.LengthError("Name is too long", 1, 100, name.Length)));
break;
}
}
if (description != null)
{
switch (description.Length)
{
case < 1:
errors.Add(("description",
ValidationError.LengthError("Description is too short", 1, 100, description.Length)));
break;
case > 500:
errors.Add(("description",
ValidationError.LengthError("Description is too long", 1, 100, description.Length)));
break;
}
}
if (imageData != null)
{
switch (imageData.Length)
{
case 0:
errors.Add(("image", ValidationError.GenericValidationError("Image cannot be empty", null)));
break;
case > 1_500_000:
errors.Add(("image", ValidationError.GenericValidationError("Image is too large", null)));
break;
}
}
return errors;
}
} }