From 661c3eab0f91221eaf45d687541146f5f232281b Mon Sep 17 00:00:00 2001 From: sam Date: Thu, 19 Dec 2024 16:19:27 +0100 Subject: [PATCH] fix(backend): save data exports as data-export.zip change the random base 64 to a directory rather than part of the filename, so that users downloading their exports aren't greeted with a completely incomprehensible file in their downloads folder --- Foxnouns.Backend/Controllers/ExportsController.cs | 2 +- Foxnouns.Backend/Jobs/CreateDataExportInvocable.cs | 2 +- Foxnouns.Backend/Services/DataCleanupService.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Foxnouns.Backend/Controllers/ExportsController.cs b/Foxnouns.Backend/Controllers/ExportsController.cs index 9d23e41..7f40625 100644 --- a/Foxnouns.Backend/Controllers/ExportsController.cs +++ b/Foxnouns.Backend/Controllers/ExportsController.cs @@ -58,7 +58,7 @@ public class ExportsController( } private string ExportUrl(Snowflake userId, string filename) => - $"{config.MediaBaseUrl}/data-exports/{userId}/{filename}.zip"; + $"{config.MediaBaseUrl}/data-exports/{userId}/{filename}/data-export.zip"; [HttpPost] public async Task QueueDataExportAsync() diff --git a/Foxnouns.Backend/Jobs/CreateDataExportInvocable.cs b/Foxnouns.Backend/Jobs/CreateDataExportInvocable.cs index 4d9e1b0..becd858 100644 --- a/Foxnouns.Backend/Jobs/CreateDataExportInvocable.cs +++ b/Foxnouns.Backend/Jobs/CreateDataExportInvocable.cs @@ -220,5 +220,5 @@ public class CreateDataExportInvocable( } private static string ExportPath(Snowflake userId, string b64) => - $"data-exports/{userId}/{b64}.zip"; + $"data-exports/{userId}/{b64}/data-export.zip"; } diff --git a/Foxnouns.Backend/Services/DataCleanupService.cs b/Foxnouns.Backend/Services/DataCleanupService.cs index 3d60462..ee60bb8 100644 --- a/Foxnouns.Backend/Services/DataCleanupService.cs +++ b/Foxnouns.Backend/Services/DataCleanupService.cs @@ -128,5 +128,5 @@ public class DataCleanupService( } private static string ExportPath(Snowflake userId, string b64) => - $"data-exports/{userId}/{b64}.zip"; + $"data-exports/{userId}/{b64}/data-export.zip"; }