feat(auth): misc fediverse auth improvements

- remove automatic app validation
- add force refresh option to GetFediverseUrlAsync
- pass state to mastodon authorization URI

Foxnouns.Backend/Services/Auth/FediverseAuthService.cs

@@ -1,7 +1,6 @@
 using Foxnouns.Backend.Database;
 using Foxnouns.Backend.Database.Models;
 using Microsoft.EntityFrameworkCore;
-using NodaTime;
 using J = System.Text.Json.Serialization.JsonPropertyNameAttribute;
 
 namespace Foxnouns.Backend.Services.Auth;
@@ -10,26 +9,27 @@ public partial class FediverseAuthService
 {
     private const string NodeInfoRel = "http://nodeinfo.diaspora.software/ns/schema/2.0";
 
-    private readonly ILogger _logger;
     private readonly HttpClient _client;
-    private readonly DatabaseContext _db;
+    private readonly ILogger _logger;
     private readonly Config _config;
+    private readonly DatabaseContext _db;
+    private readonly KeyCacheService _keyCacheService;
     private readonly ISnowflakeGenerator _snowflakeGenerator;
-    private readonly IClock _clock;
 
     public FediverseAuthService(
         ILogger logger,
         Config config,
         DatabaseContext db,
-        ISnowflakeGenerator snowflakeGenerator,
-        IClock clock
+        KeyCacheService keyCacheService,
+        ISnowflakeGenerator snowflakeGenerator
     )
     {
+        _logger = logger.ForContext<FediverseAuthService>();
         _config = config;
         _db = db;
+        _keyCacheService = keyCacheService;
         _snowflakeGenerator = snowflakeGenerator;
-        _clock = clock;
-        _logger = logger.ForContext<FediverseAuthService>();
+
         _client = new HttpClient();
         _client.DefaultRequestHeaders.Remove("User-Agent");
         _client.DefaultRequestHeaders.Remove("Accept");
@@ -37,10 +37,10 @@ public partial class FediverseAuthService
         _client.DefaultRequestHeaders.Add("Accept", "application/json");
     }
 
-    public async Task<string> GenerateAuthUrlAsync(string instance)
+    public async Task<string> GenerateAuthUrlAsync(string instance, bool forceRefresh)
     {
         var app = await GetApplicationAsync(instance);
-        return await GenerateAuthUrlAsync(app);
+        return await GenerateAuthUrlAsync(app, forceRefresh);
     }
 
     // thank you, gargron and syuilo, for agreeing on a name for *once* in your lives,
@@ -96,21 +96,25 @@ public partial class FediverseAuthService
             );
     }
 
-    private async Task<string> GenerateAuthUrlAsync(FediverseApplication app) =>
+    private async Task<string> GenerateAuthUrlAsync(FediverseApplication app, bool forceRefresh) =>
         app.InstanceType switch
         {
-            FediverseInstanceType.MastodonApi => await GenerateMastodonAuthUrlAsync(app),
+            FediverseInstanceType.MastodonApi => await GenerateMastodonAuthUrlAsync(
+                app,
+                forceRefresh
+            ),
             FediverseInstanceType.MisskeyApi => throw new NotImplementedException(),
             _ => throw new ArgumentOutOfRangeException(nameof(app), app.InstanceType, null),
         };
 
     public async Task<FediverseUser> GetRemoteFediverseUserAsync(
         FediverseApplication app,
-        string code
+        string code,
+        string state
     ) =>
         app.InstanceType switch
         {
-            FediverseInstanceType.MastodonApi => await GetMastodonUserAsync(app, code),
+            FediverseInstanceType.MastodonApi => await GetMastodonUserAsync(app, code, state),
             FediverseInstanceType.MisskeyApi => throw new NotImplementedException(),
             _ => throw new ArgumentOutOfRangeException(nameof(app), app.InstanceType, null),
         };