From c06376dfda0e4c673c76dba477f99ecae66045cc Mon Sep 17 00:00:00 2001
From: sam <sam@starshines.gay>
Date: Tue, 19 Nov 2024 20:30:05 +0100
Subject: [PATCH] im stupid and NewsService._isExpired could literally never
 fire

---
 Catalogger.Backend/Services/NewsService.cs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Catalogger.Backend/Services/NewsService.cs b/Catalogger.Backend/Services/NewsService.cs
index e52c783..3adfebe 100644
--- a/Catalogger.Backend/Services/NewsService.cs
+++ b/Catalogger.Backend/Services/NewsService.cs
@@ -34,8 +34,9 @@ public class NewsService(
 
     private readonly ILogger _logger = logger.ForContext<NewsService>();
     private List<IMessage>? _messages;
+    private Instant _lastUpdated = Instant.MinValue;
     private readonly SemaphoreSlim _lock = new(1);
-    private bool _isExpired => clock.GetCurrentInstant() > clock.GetCurrentInstant() + ExpiresAfter;
+    private bool _isExpired => clock.GetCurrentInstant() > _lastUpdated + ExpiresAfter;
 
     public async Task<IEnumerable<NewsMessage>> GetNewsAsync()
     {
@@ -74,6 +75,7 @@ public class NewsService(
         }
         finally
         {
+            _lastUpdated = clock.GetCurrentInstant();
             _lock.Release();
         }
     }