diff --git a/.editorconfig b/.editorconfig index d20e217..1e5c57b 100644 --- a/.editorconfig +++ b/.editorconfig @@ -14,4 +14,7 @@ resharper_entity_framework_model_validation_unlimited_string_length_highlighting # This is raised for every single property of records returned by endpoints resharper_not_accessed_positional_property_local_highlighting = none # ReSharper yells at us for the name "GuildCache", for some reason -resharper_inconsistent_naming_highlighting = none \ No newline at end of file +resharper_inconsistent_naming_highlighting = none +# From the docs: "You might consider excluding [FirstOrDefault or LastOrDefault] if readability is a concern, +# since the code you'd write to replace them is not easily readable." +dotnet_code_quality.CA1826.exclude_ordefault_methods = true \ No newline at end of file diff --git a/Catalogger.Backend/Bot/Commands/IgnoreChannelCommands.cs b/Catalogger.Backend/Bot/Commands/IgnoreChannelCommands.cs index 63dce5e..73b0a21 100644 --- a/Catalogger.Backend/Bot/Commands/IgnoreChannelCommands.cs +++ b/Catalogger.Backend/Bot/Commands/IgnoreChannelCommands.cs @@ -142,11 +142,6 @@ public class IgnoreChannelCommands( }) .ToList(); - foreach (var ch in ignoredChannels) - { - _logger.Debug("Channel: {ChannelId}, type: {Type}", ch.Id, ch.Type); - } - var embed = new EmbedBuilder() .WithTitle($"Ignored channels in {guild.Name}") .WithColour(DiscordUtils.Purple); diff --git a/Catalogger.Backend/Bot/Responders/Messages/MessageCreateResponder.cs b/Catalogger.Backend/Bot/Responders/Messages/MessageCreateResponder.cs index 47cf10c..3eebf2f 100644 --- a/Catalogger.Backend/Bot/Responders/Messages/MessageCreateResponder.cs +++ b/Catalogger.Backend/Bot/Responders/Messages/MessageCreateResponder.cs @@ -88,18 +88,11 @@ public partial class PkMessageHandler(ILogger logger, IServiceProvider services) public async Task HandlePkMessageAsync(IMessageCreate msg) { - _logger.Debug("Received PluralKit message"); - await Task.Delay(500.Milliseconds()); - _logger.Debug("Starting handling PluralKit message"); - // Check if the content matches a Discord link--if not, it's not a log message (we already check if this is a PluralKit message earlier) if (!LinkRegex().IsMatch(msg.Content)) - { - _logger.Debug("PluralKit message is not a log message because content is not a link"); return; - } // The first (only, I think always?) embed's footer must match the expected format var firstEmbed = msg.Embeds.FirstOrDefault(); @@ -108,12 +101,7 @@ public partial class PkMessageHandler(ILogger logger, IServiceProvider services) || !firstEmbed.Footer.TryGet(out var footer) || !FooterRegex().IsMatch(footer.Text) ) - { - _logger.Debug( - "PK message is not a log message because there is no first embed or its footer doesn't match the regex" - ); return; - } var match = FooterRegex().Match(footer.Text); diff --git a/Catalogger.Backend/Bot/Responders/Messages/MessageUpdateResponder.cs b/Catalogger.Backend/Bot/Responders/Messages/MessageUpdateResponder.cs index 1dd9290..023cab1 100644 --- a/Catalogger.Backend/Bot/Responders/Messages/MessageUpdateResponder.cs +++ b/Catalogger.Backend/Bot/Responders/Messages/MessageUpdateResponder.cs @@ -58,10 +58,7 @@ public class MessageUpdateResponder( var guildConfig = await guildRepository.GetAsync(msg.GuildID); if (await messageRepository.IsMessageIgnoredAsync(msg.ID.Value)) - { - _logger.Debug("Message {MessageId} should be ignored", msg.ID); return Result.Success; - } try { diff --git a/Catalogger.Backend/Services/WebhookExecutorService.cs b/Catalogger.Backend/Services/WebhookExecutorService.cs index dfde9b2..df2a122 100644 --- a/Catalogger.Backend/Services/WebhookExecutorService.cs +++ b/Catalogger.Backend/Services/WebhookExecutorService.cs @@ -61,7 +61,6 @@ public class WebhookExecutorService( public void QueueLog(Guild guildConfig, LogChannelType logChannelType, IEmbed embed) { var logChannel = GetLogChannel(guildConfig, logChannelType, channelId: null, userId: null); - _logger.Debug("Channel to log {Type} to: {LogChannel}", logChannelType, logChannel); if (logChannel == null) return; @@ -73,7 +72,6 @@ public class WebhookExecutorService( /// public void QueueLog(ulong channelId, IEmbed embed) { - _logger.Debug("Channel to log to: {LogChannel}", channelId); if (channelId == 0) return;